Skip to content

DNM: TP combine #32 + #33 - #34

Open
tusharjadhav3302 wants to merge 11 commits into
mainfrom
tp-combine-32-33
Open

DNM: TP combine #32 + #33#34
tusharjadhav3302 wants to merge 11 commits into
mainfrom
tp-combine-32-33

Conversation

@tusharjadhav3302

@tusharjadhav3302 tusharjadhav3302 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Why

CIFMW accepts only one cifmw_shiftstack_qa_gerrithub_change ref. TP needs both fixes in a single checkout.

Test plan

  • Point TP MR at refs/pull/<this>/head and recheck
  • Close this PR / delete branch after validation

Made with Cursor

tusharjadhav3302 and others added 5 commits August 6, 2026 14:29
@tusharjadhav3302 @cursoragent
Harden verification OpenStack CLI calls to use JSON output
f7026c8 
Replace fragile -f value/-c/csv+grep parsing in Priority A verification
tasks with -f json and structured parsing so OSC formatter drift (e.g.
Invalid formatter provided on floating ip show) no longer fails nightlies.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tusharjadhav3302 @cursoragent
Use floating ip list instead of broken show -f formatters
3ed31c1 
On shiftstackclient OSC, `openstack floating ip show … -f *` always
returns Invalid formatter provided. Look up Fixed IP Address via
`floating ip list --floating-ip-address … -f json` instead.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tusharjadhav3302 @cursoragent
Adapt openstack_test stage to OTE after legacy Makefile drop
ec46f4e 
Upstream openstack-test removed make openstack-tests on release-4.20+
(PR #303 and backports). Use make extension / run-suite for those
releases, keep the legacy path for older branches, and preserve
run-test/junit exit codes for filtered runs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tusharjadhav3302
Merge PR #32 (OSC JSON verification) for TP validation
959717e
@tusharjadhav3302
Merge PR #33 (OTE openstack_test) for TP validation
13d36d0
@openshift-ci

openshift-ci Bot commented Aug 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gryf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tusharjadhav3302 and others added 2 commits August 10, 2026 12:06
@tusharjadhav3302 @cursoragent
Resolve OTE run-suite false failures from klog deserialize errors
5abe8ef 
Outer JSON marks every result failed when stderr starts with klog "I..."
lines. Count and rewrite junit from nested STDOUT / ginkgo SUCCESS|FAIL
so real suite failures stay UNSTABLE instead of "no tests run".

Co-authored-by: Cursor <cursoragent@cursor.com>
@tusharjadhav3302
Merge PR #33 OTE result-resolve fix into TP combine branch
d75b0e5
@tusharjadhav3302

tusharjadhav3302 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Refreshed with latest #33 (OTE result resolve: `5abe8ef`). No TP recheck requested yet.

tusharjadhav3302 and others added 2 commits August 10, 2026 12:42
@tusharjadhav3302 @cursoragent
Keep OTE pass/fail counts when legacy count tasks are skipped
5781579 
Skipped Ansible tasks still overwrite a shared register, which cleared
OTE resolved counts and falsely triggered "no tests where run!".

Co-authored-by: Cursor <cursoragent@cursor.com>
@tusharjadhav3302
Merge PR #33 register-count fix into TP combine branch
954676c
@tusharjadhav3302

tusharjadhav3302 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Refreshed with #33 register-count fix (5781579). Ready for TP recheck when you want it.

@tusharjadhav3302

tusharjadhav3302 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Manual validation note (throwaway combine #32+#33)

Used this PR’s tip on serval71 shiftstackclient (refs/pull/34/head / branch tp-combine-32-33 through 954676c) to validate both stacked fixes against a live RHOSO + guest OCP 4.23 cluster.

#32 (OSC JSON verification)

#33 (OTE + result resolve + register fix)

Full stages: ["openstack_test"] run with hypervisor=serval71.lab.eng.tlv2.redhat.com:

  • Outer OTE: Error: 51 tests failed (expected deserialize noise)
  • Resolved counts: passed=20, failed=11
  • Marked UNSTABLE; did not hit openstack-test execution failed or no tests where run!
  • must-gather + post XML/HTML completed; PLAY RECAP failed=0, rescued=1

Offline resolver check on previous CI log: 24 / 7 / 20 (passed/failed/skipped).

DNM — close after TP recheck; do not merge this PR. Land #32 and #33 separately.

This was referenced Aug 10, 2026
Open
Open
@tusharjadhav3302

tusharjadhav3302 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Manual validation note (throwaway combine #32+#33)

Used this PR’s tip on serval71 shiftstackclient (refs/pull/34/head / branch tp-combine-32-33 through 954676c) to validate both stacked fixes against a live RHOSO + guest OCP 4.23 cluster.

#32 (OSC JSON verification)

#33 (OTE + result resolve + register fix)

Full stages: ["openstack_test"] run with hypervisor=serval71.lab.eng.tlv2.redhat.com:

  • Outer OTE: Error: 51 tests failed (expected deserialize noise)
  • Resolved counts: passed=20, failed=11
  • Marked UNSTABLE; did not hit openstack-test execution failed or no tests where run!
  • must-gather + post XML/HTML completed; PLAY RECAP failed=0, rescued=1

Offline resolver check on previous CI log: 24 / 7 / 20 (passed/failed/skipped).

DNM — close after TP recheck; do not merge this PR. Land #32 and #33 separately.

tusharjadhav3302 and others added 2 commits August 10, 2026 13:33
@tusharjadhav3302 @cursoragent
Fix OTE allowlist matching for lb/egressip filtered stages
3259e02 
OTE list -o names emits unquoted names plus klog on stdout, while
allowlists are converted as quoted patterns for legacy dry-run. Strip
optional quotes, drop klog lines, and filter list stdout so .*[lb].*
matches again.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tusharjadhav3302
Merge PR #33 OTE allowlist/klog filter fix into TP combine
a65fb57
@tusharjadhav3302

tusharjadhav3302 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Refreshed with #33 allowlist/OTE list fix (3259e02). Reinstall collection from this tip before continuing manual lb_tests/egressip_tests.

@tusharjadhav3302

tusharjadhav3302 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Manual validation complete — Zuul recheck still planned

Throwaway combine (#32 + #33) validated end-to-end on serval71 live cluster (no reprovision):

Tip used for last stages included allowlist fix 3259e02 / merge a65fb57.

Next: recheck testproject !2584 (refs/pull/34/head) for Zuul green, then close this DNM PR; land #32 and #33 separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenwng chenwng Awaiting requested review from chenwng chenwng is a code owner
@dlaw4608 dlaw4608 Awaiting requested review from dlaw4608 dlaw4608 is a code owner
@ekuris-redhat ekuris-redhat Awaiting requested review from ekuris-redhat ekuris-redhat is a code owner
@eshulman2 eshulman2 Awaiting requested review from eshulman2 eshulman2 is a code owner
@gryf gryf Awaiting requested review from gryf gryf is a code owner
@imatza-rh imatza-rh Awaiting requested review from imatza-rh imatza-rh is a code owner
@mandre mandre Awaiting requested review from mandre mandre is a code owner
@stephenfin stephenfin Awaiting requested review from stephenfin stephenfin is a code owner
@winiciusallan winiciusallan Awaiting requested review from winiciusallan winiciusallan is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tusharjadhav3302